Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: pkg/analyzer/lib/src/generated/resolver.dart

Issue 2002353003: Don't short circuit visiting else (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/resolver.dart b/pkg/analyzer/lib/src/generated/resolver.dart
index 8f0038abd93fdb634df6c3596d64bb03e0241e69..7dbf6e42c99492dbe9054a776fd77d0869c52b5e 100644
--- a/pkg/analyzer/lib/src/generated/resolver.dart
+++ b/pkg/analyzer/lib/src/generated/resolver.dart
@@ -3690,7 +3690,9 @@ class ExitDetector extends GeneralizingAstVisitor<bool> {
if (thenStatement == null || elseStatement == null) {
return false;
}
- return _nodeExits(thenStatement) && _nodeExits(elseStatement);
+ bool thenExits = _nodeExits(thenStatement);
+ bool elseExits = _nodeExits(elseStatement);
+ return thenExits && elseExits;
}
@override
« no previous file with comments | « no previous file | pkg/analyzer/test/generated/all_the_rest_test.dart » ('j') | pkg/analyzer/test/generated/all_the_rest_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698