Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chrome/browser/resources/media_router/elements/route_details/route_details.html

Issue 2002293003: [Media Router] Allow casting new media to sink with existing route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/route_details/route_details.html
diff --git a/chrome/browser/resources/media_router/elements/route_details/route_details.html b/chrome/browser/resources/media_router/elements/route_details/route_details.html
index 9fc321f67624a237377c4ceb2ad839ea412eeb63..47a0e14d5b8ef616bc8691f71722a697d82190ec 100644
--- a/chrome/browser/resources/media_router/elements/route_details/route_details.html
+++ b/chrome/browser/resources/media_router/elements/route_details/route_details.html
@@ -14,7 +14,6 @@
<div id="route-action-buttons" class="layout">
<paper-button flat class="route-button button"
id="start-casting-to-route-button"
- hidden$="[[!route.canJoin]]"
amp 2016/05/23 21:42:35 It would be nice to update this logic to make it h
btolsch 2016/05/23 22:41:10 The UI sets route.canJoin by matching a list of jo
mark a. foltz 2016/05/23 23:53:38 Does this remove the entire logic about when to sh
btolsch 2016/05/24 20:20:18 route.canJoin would still be necessary, but in any
on-tap="startCastingToRoute_">
<span>[[i18n('startCastingButtonText')]]</span>
</paper-button>

Powered by Google App Engine
This is Rietveld 408576698