Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Side by Side Diff: chrome/browser/resources/media_router/elements/route_details/route_details.html

Issue 2002293003: [Media Router] Allow casting new media to sink with existing route. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <link rel="import" href="chrome://resources/html/polymer.html"> 1 <link rel="import" href="chrome://resources/html/polymer.html">
2 <link rel="import" href="chrome://resources/html/i18n_behavior.html"> 2 <link rel="import" href="chrome://resources/html/i18n_behavior.html">
3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html"> 3 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-butt on.html">
4 <dom-module id="route-details"> 4 <dom-module id="route-details">
5 <link rel="import" type="css" href="../../media_router_common.css"> 5 <link rel="import" type="css" href="../../media_router_common.css">
6 <link rel="import" type="css" href="route_details.css"> 6 <link rel="import" type="css" href="route_details.css">
7 <template> 7 <template>
8 <div id="route-information" hidden$="[[!isCustomControllerHidden_]]"> 8 <div id="route-information" hidden$="[[!isCustomControllerHidden_]]">
9 <span>[[activityStatus_]]</span> 9 <span>[[activityStatus_]]</span>
10 </div> 10 </div>
11 <extensionview id="custom-controller" 11 <extensionview id="custom-controller"
12 hidden$="[[isCustomControllerHidden_]]"> 12 hidden$="[[isCustomControllerHidden_]]">
13 </extensionview> 13 </extensionview>
14 <div id="route-action-buttons" class="layout"> 14 <div id="route-action-buttons" class="layout">
15 <paper-button flat class="route-button button" 15 <paper-button flat class="route-button button"
16 id="start-casting-to-route-button" 16 id="start-casting-to-route-button"
17 hidden$="[[!route.canJoin]]"
amp 2016/05/23 21:42:35 It would be nice to update this logic to make it h
btolsch 2016/05/23 22:41:10 The UI sets route.canJoin by matching a list of jo
mark a. foltz 2016/05/23 23:53:38 Does this remove the entire logic about when to sh
btolsch 2016/05/24 20:20:18 route.canJoin would still be necessary, but in any
18 on-tap="startCastingToRoute_"> 17 on-tap="startCastingToRoute_">
19 <span>[[i18n('startCastingButtonText')]]</span> 18 <span>[[i18n('startCastingButtonText')]]</span>
20 </paper-button> 19 </paper-button>
21 <paper-button flat class="route-button button" 20 <paper-button flat class="route-button button"
22 id="close-route-button" 21 id="close-route-button"
23 on-tap="closeRoute_"> 22 on-tap="closeRoute_">
24 <span>[[i18n('stopCastingButtonText')]]</span> 23 <span>[[i18n('stopCastingButtonText')]]</span>
25 </paper-button> 24 </paper-button>
26 <div> 25 <div>
27 </template> 26 </template>
28 <script src="route_details.js"></script> 27 <script src="route_details.js"></script>
29 </dom-module> 28 </dom-module>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698