Issue 2002253005: Speculatively revert "Make the object store visible in Observatory."

Issue 2002253005: Speculatively revert "Make the object store visible in Observatory." (Closed)

Created:
4 years, 7 months ago by rmacnak

Modified:
4 years, 7 months ago

Reviewers:
turnidge

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Speculatively revert "Make the object store visible in Observatory." This reverts commit 2eb84089698465ecd0fa133c5331a69088fc86fa. TBR=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/7bdf01560a70e089774b47c2cbd5823da790374e

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+82 lines, -283 lines)			Patch
M	runtime/observatory/lib/elements.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/elements.html	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/isolate_view.html	View	2 chunks	+0 lines, -7 lines	0 comments	Download
D	runtime/observatory/lib/src/elements/objectstore_ref.dart	View	1 chunk	+0 lines, -16 lines	0 comments	Download
D	runtime/observatory/lib/src/elements/objectstore_ref.html	View	1 chunk	+0 lines, -20 lines	0 comments	Download
D	runtime/observatory/lib/src/elements/objectstore_view.dart	View	1 chunk	+0 lines, -22 lines	0 comments	Download
D	runtime/observatory/lib/src/elements/objectstore_view.html	View	1 chunk	+0 lines, -46 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/service_ref.dart	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/service_view.dart	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	4 chunks	+0 lines, -35 lines	0 comments	Download
M	runtime/observatory/observatory_sources.gypi	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/isolate.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/object_store.h	View	1 chunk	+82 lines, -90 lines	0 comments	Download
M	runtime/vm/object_store.cc	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 2 (1 generated)

rmacnak

4 years, 7 months ago (2016-05-26 00:33:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7bdf01560a70e089774b47c2cbd5823da790374e (presubmit successful).