Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: runtime/vm/service.cc

Issue 2002253005: Speculatively revert "Make the object store visible in Observatory." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/object_store.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/service.h" 5 #include "vm/service.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "include/dart_native_api.h" 8 #include "include/dart_native_api.h"
9 #include "platform/globals.h" 9 #include "platform/globals.h"
10 10
(...skipping 3574 matching lines...) Expand 10 before | Expand all | Expand 10 after
3585 // Handle non-heap objects. 3585 // Handle non-heap objects.
3586 Breakpoint* bpt = LookupBreakpoint(thread->isolate(), id, &lookup_result); 3586 Breakpoint* bpt = LookupBreakpoint(thread->isolate(), id, &lookup_result);
3587 if (bpt != NULL) { 3587 if (bpt != NULL) {
3588 bpt->PrintJSON(js); 3588 bpt->PrintJSON(js);
3589 return true; 3589 return true;
3590 } else if (lookup_result == ObjectIdRing::kCollected) { 3590 } else if (lookup_result == ObjectIdRing::kCollected) {
3591 PrintSentinel(js, kCollectedSentinel); 3591 PrintSentinel(js, kCollectedSentinel);
3592 return true; 3592 return true;
3593 } 3593 }
3594 3594
3595 if (strcmp(id, "object_store") == 0) {
3596 JSONObject jsobj(js);
3597 thread->isolate()->object_store()->PrintToJSONObject(&jsobj, false);
3598 return true;
3599 }
3600
3601 PrintInvalidParamError(js, "objectId"); 3595 PrintInvalidParamError(js, "objectId");
3602 return true; 3596 return true;
3603 } 3597 }
3604 3598
3605 3599
3606 static const MethodParameter* get_class_list_params[] = { 3600 static const MethodParameter* get_class_list_params[] = {
3607 RUNNABLE_ISOLATE_PARAMETER, 3601 RUNNABLE_ISOLATE_PARAMETER,
3608 NULL, 3602 NULL,
3609 }; 3603 };
3610 3604
(...skipping 437 matching lines...) Expand 10 before | Expand all | Expand 10 after
4048 if (strcmp(method_name, method.name) == 0) { 4042 if (strcmp(method_name, method.name) == 0) {
4049 return &method; 4043 return &method;
4050 } 4044 }
4051 } 4045 }
4052 return NULL; 4046 return NULL;
4053 } 4047 }
4054 4048
4055 #endif // !PRODUCT 4049 #endif // !PRODUCT
4056 4050
4057 } // namespace dart 4051 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/object_store.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698