src/effects/gradients/SkGradientShader.cpp - Issue 200223008: Remove SkCanvas matrix ops return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkGradientShader.cpp

Issue 200223008: Remove SkCanvas matrix ops return value. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Updated per comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkGradientShader.cpp

diff --git a/src/effects/gradients/SkGradientShader.cpp b/src/effects/gradients/SkGradientShader.cpp

index cd448b9cb89f901a70933e1651bb2480d3bf1b20..b1fa560dfcc13df980c92815711e22a1932202be 100644

--- a/src/effects/gradients/SkGradientShader.cpp

+++ b/src/effects/gradients/SkGradientShader.cpp

@@ -233,12 +233,7 @@ bool SkGradientShaderBase::setContext(const SkBitmap& device,

const SkMatrix& inverse = this->getTotalInverse();

- if (!fDstToIndex.setConcat(fPtsToUnit, inverse)) {

- // need to keep our set/end context calls balanced.

- this->INHERITED::endContext();

- return false;

- }

+ fDstToIndex.setConcat(fPtsToUnit, inverse);

fDstToIndexProc = fDstToIndex.getMapXYProc();

fDstToIndexClass = (uint8_t)SkShader::ComputeMatrixClass(fDstToIndex);