src/pdf/SkPDFDevice.cpp - Issue 200223008: Remove SkCanvas matrix ops return value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDevice.cpp

Issue 200223008: Remove SkCanvas matrix ops return value. (Closed) Base URL: https://skia.googlecode.com/svn/trunk

Patch Set: Updated per comments Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/pdf/SkPDFDevice.cpp

diff --git a/src/pdf/SkPDFDevice.cpp b/src/pdf/SkPDFDevice.cpp

index efd2b02b50709a53d169d9697616563b3f168c59..2f0ed0cbe2c686cce4ff06daac53ae827fe808b7 100644

--- a/src/pdf/SkPDFDevice.cpp

+++ b/src/pdf/SkPDFDevice.cpp

@@ -983,10 +983,7 @@ void SkPDFDevice::drawPath(const SkDraw& d, const SkPath& origPath,

}

origPath.transform(*prePathMatrix, pathPtr);

} else {

- if (!matrix.preConcat(*prePathMatrix)) {

- // TODO(edisonn): report somehow why we failed?

- return;

- }

+ matrix.preConcat(*prePathMatrix);

}