Remove SkCanvas matrix ops return value.

Remove SkCanvas matrix ops return value.

The internal SkMatrix ops can no longer fail -> we can remove the bool
return value.

R=reed@google.com,robertphillips@google.com,bsalomon@google.com,scroggo@google.com

Committed: http://code.google.com/p/skia/source/detail?r=13849

[f(malita), 2014-03-14 16:09:01]

Chromium requires one GraphicsContext internal API tweak.

Android is a big unknown.

[reed1, 2014-03-14 17:11:07]

lgtm

[robertphillips, 2014-03-14 17:35:18]

https://codereview.chromium.org/200223008/diff/20001/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/200223008/diff/20001/src/core/SkMatrix.cpp#ne...
src/core/SkMatrix.cpp:325: void SkMatrix::preScale(SkScalar sx, SkScalar sy,
SkScalar px, SkScalar py) {
Why no sx & sy checks here? All the other kids get them.

[fmalita_google_do_not_use, 2014-03-14 17:39:13]

https://codereview.chromium.org/200223008/diff/20001/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/200223008/diff/20001/src/core/SkMatrix.cpp#ne...
src/core/SkMatrix.cpp:325: void SkMatrix::preScale(SkScalar sx, SkScalar sy,
SkScalar px, SkScalar py) {
On 2014/03/14 17:35:18, robertphillips wrote:
> Why no sx & sy checks here? All the other kids get them.

I had to leave for Chipotle ;)

(will do)

[f(malita), 2014-03-17 13:43:33]

Chromium usage updated
(https://src.chromium.org/viewvc/blink?revision=169305&view=revision), this
should be good to go assuming Android doesn't depend on the old API.

[scroggo, 2014-03-17 14:51:52]

On 2014/03/17 13:43:33, Florin Malita wrote:
> Chromium usage updated
> (https://src.chromium.org/viewvc/blink?revision=169305&view=revision), this
> should be good to go assuming Android doesn't depend on the old API.

Android should be fine. Their public API Canvas returns void already. Their
Matrix API returns bool, but if anyone depends on it we can do the checks on
their end.

[f(malita), 2014-03-18 12:45:38]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-03-18 12:45:46]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/200223008/40001

[f(malita), 2014-03-18 12:45:56]

The CQ bit was unchecked by fmalita@chromium.org

[f(malita), 2014-03-18 12:46:23]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2014-03-18 12:46:32]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/200223008/40001

[commit-bot: I haz the power, 2014-03-18 12:51:55]

Change committed as 13849

[scroggo, 2014-04-02 14:53:36]

https://codereview.chromium.org/200223008/diff/40001/src/core/SkMatrix.cpp
File src/core/SkMatrix.cpp (right):

https://codereview.chromium.org/200223008/diff/40001/src/core/SkMatrix.cpp#ne...
src/core/SkMatrix.cpp:596: return SkDoubleToFloat((double)a * b + (double)c *
d);
I know this is not a change in behavior, but is there a reason we decided not to
consider the possibility that these computations might overflow float?

https://codereview.chromium.org/200223008/diff/40001/src/core/SkMatrix.cpp#ne...
src/core/SkMatrix.cpp:600: return row[0] * col[0] + row[1] * col[3] + row[2] *
col[6];
Same question.