Chromium Code Reviews| Index: src/keys.h |
| diff --git a/src/keys.h b/src/keys.h |
| index 4f99bb5bd43e5e03ac9536fe01dea2de83cba18d..dc52bd56767d01b2c329de4cd3adcb7d241447ff 100644 |
| --- a/src/keys.h |
| +++ b/src/keys.h |
| @@ -31,14 +31,14 @@ enum AddKeyConversion { DO_NOT_CONVERT, CONVERT_TO_ARRAY_INDEX }; |
| // are more compact and allow for reasonably fast includes check. |
| class KeyAccumulator final BASE_EMBEDDED { |
| public: |
| - KeyAccumulator(Isolate* isolate, KeyCollectionType type, |
| + KeyAccumulator(Isolate* isolate, KeysCollectionLimit type, |
|
Igor Sheludko
2016/05/25 14:52:56
I would rename |type| here, below and above as wel
|
| PropertyFilter filter) |
| : isolate_(isolate), type_(type), filter_(filter) {} |
| ~KeyAccumulator(); |
| static MaybeHandle<FixedArray> GetKeys( |
| - Handle<JSReceiver> object, KeyCollectionType type, PropertyFilter filter, |
| - GetKeysConversion keys_conversion = KEEP_NUMBERS, |
| + Handle<JSReceiver> object, KeysCollectionLimit type, |
| + PropertyFilter filter, GetKeysConversion keys_conversion = KEEP_NUMBERS, |
| bool filter_proxy_keys = true, bool is_for_in = false); |
| Handle<FixedArray> GetKeys(GetKeysConversion convert = KEEP_NUMBERS); |
| Maybe<bool> CollectKeys(Handle<JSReceiver> receiver, |
| @@ -81,7 +81,7 @@ class KeyAccumulator final BASE_EMBEDDED { |
| // keys_ is either an Handle<OrderedHashSet> or in the case of own JSProxy |
| // keys a Handle<FixedArray>. |
| Handle<FixedArray> keys_; |
| - KeyCollectionType type_; |
| + KeysCollectionLimit type_; |
| PropertyFilter filter_; |
| bool filter_proxy_keys_ = true; |
| bool is_for_in_ = false; |
| @@ -96,7 +96,7 @@ class KeyAccumulator final BASE_EMBEDDED { |
| class FastKeyAccumulator { |
| public: |
| FastKeyAccumulator(Isolate* isolate, Handle<JSReceiver> receiver, |
| - KeyCollectionType type, PropertyFilter filter) |
| + KeysCollectionLimit type, PropertyFilter filter) |
| : isolate_(isolate), receiver_(receiver), type_(type), filter_(filter) { |
| Prepare(); |
| } |
| @@ -115,7 +115,7 @@ class FastKeyAccumulator { |
| Isolate* isolate_; |
| Handle<JSReceiver> receiver_; |
| - KeyCollectionType type_; |
| + KeysCollectionLimit type_; |
| PropertyFilter filter_; |
| bool filter_proxy_keys_ = true; |
| bool is_for_in_ = false; |