Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Unified Diff: include/v8.h

Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-05-06_keys_fast_path_1995263002
Patch Set: reverting accidental formatting Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/keys.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index b5db5fe4295d11d17589fdeb07fefdbf2cde7e81..916e6a551aa09849a00a720c89b9d0c6379c304a 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -2631,6 +2631,10 @@ enum PropertyFilter {
SKIP_SYMBOLS = 16
};
+enum KeysCollectionLimit { OWN_ONLY, INCLUDE_PROTOS };
Igor Sheludko 2016/05/25 14:52:56 WDYT about KeyCollectionMode? Why not enum class?
Camillo Bruni 2016/05/27 12:58:37 right, seems like a better choice.
+
+enum IndexFilter { INCLUDE_INDICES, SKIP_INDICES };
+
/**
* Integrity level for objects.
*/
@@ -2780,6 +2784,9 @@ class V8_EXPORT Object : public Value {
V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetPropertyNames());
V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(
Local<Context> context);
+ V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(
+ Local<Context> context, KeysCollectionLimit limit,
+ PropertyFilter property_filter, IndexFilter index_filter);
/**
* This function has the same functionality as GetPropertyNames but
« no previous file with comments | « no previous file | src/api.cc » ('j') | src/keys.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698