src/objects-inl.h - Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 2002203002: [api] Add more parameters to Object::GetPropertyNames (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@2016-05-06_keys_fast_path_1995263002

Patch Set: addressing nits Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index f873f9478bcf5964b0fa4b47967c01a772c420db..3e28102fc76ed4958209b28b955eb8dbf7319c7d 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -1114,8 +1114,9 @@ MaybeHandle<Object> JSReceiver::GetProperty(Isolate* isolate,

// static

MUST_USE_RESULT MaybeHandle<FixedArray> JSReceiver::OwnPropertyKeys(

Handle<JSReceiver> object) {

- return KeyAccumulator::GetKeys(object, OWN_ONLY, ALL_PROPERTIES,

- CONVERT_TO_STRING);

+ return KeyAccumulator::GetKeys(object, KeyCollectionMode::kOwnOnly,

+ ALL_PROPERTIES,

+ GetKeysConversion::kConvertToString);

}

#define FIELD_ADDR(p, offset) \

« no previous file with comments | « src/objects.cc ('k') | src/runtime/runtime-array.cc » ('j') | no next file with comments »