Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h

Issue 2002153007: Refactor to simplify how layerType is stored on PaintLayers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2006, 2007, 2009 Apple Inc. All rights reserved.
5 * Copyright (C) 2010 Google Inc. All rights reserved. 5 * Copyright (C) 2010 Google Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 359 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 } 370 }
371 // Move all of the kids from |startChild| up to but excluding |endChild|. 0 can be passed as the |endChild| to denote 371 // Move all of the kids from |startChild| up to but excluding |endChild|. 0 can be passed as the |endChild| to denote
372 // that all the kids from |startChild| onwards should be moved. 372 // that all the kids from |startChild| onwards should be moved.
373 void moveChildrenTo(LayoutBoxModelObject* toBoxModelObject, LayoutObject* st artChild, LayoutObject* endChild, bool fullRemoveInsert = false) 373 void moveChildrenTo(LayoutBoxModelObject* toBoxModelObject, LayoutObject* st artChild, LayoutObject* endChild, bool fullRemoveInsert = false)
374 { 374 {
375 moveChildrenTo(toBoxModelObject, startChild, endChild, 0, fullRemoveInse rt); 375 moveChildrenTo(toBoxModelObject, startChild, endChild, 0, fullRemoveInse rt);
376 } 376 }
377 virtual void moveChildrenTo(LayoutBoxModelObject* toBoxModelObject, LayoutOb ject* startChild, LayoutObject* endChild, LayoutObject* beforeChild, bool fullRe moveInsert = false); 377 virtual void moveChildrenTo(LayoutBoxModelObject* toBoxModelObject, LayoutOb ject* startChild, LayoutObject* endChild, LayoutObject* beforeChild, bool fullRe moveInsert = false);
378 378
379 private: 379 private:
380 void createLayer(PaintLayerType); 380 void createLayer();
381 381
382 LayoutUnit computedCSSPadding(const Length&) const; 382 LayoutUnit computedCSSPadding(const Length&) const;
383 bool isBoxModelObject() const final { return true; } 383 bool isBoxModelObject() const final { return true; }
384 384
385 LayoutBoxModelObjectRareData& ensureRareData() 385 LayoutBoxModelObjectRareData& ensureRareData()
386 { 386 {
387 if (!m_rareData) 387 if (!m_rareData)
388 m_rareData = adoptPtr(new LayoutBoxModelObjectRareData()); 388 m_rareData = adoptPtr(new LayoutBoxModelObjectRareData());
389 return *m_rareData.get(); 389 return *m_rareData.get();
390 } 390 }
391 391
392 // The PaintLayer associated with this object. 392 // The PaintLayer associated with this object.
393 // |m_layer| can be nullptr depending on the return value of layerTypeRequir ed(). 393 // |m_layer| can be nullptr depending on the return value of layerTypeRequir ed().
394 OwnPtr<PaintLayer> m_layer; 394 OwnPtr<PaintLayer> m_layer;
395 395
396 OwnPtr<LayoutBoxModelObjectRareData> m_rareData; 396 OwnPtr<LayoutBoxModelObjectRareData> m_rareData;
397 }; 397 };
398 398
399 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject()); 399 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBoxModelObject, isBoxModelObject());
400 400
401 } // namespace blink 401 } // namespace blink
402 402
403 #endif // LayoutBoxModelObject_h 403 #endif // LayoutBoxModelObject_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698