Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2002143002: [stubs] An easier way of defining a stub call interface descriptor. (Closed)

Created:
4 years, 7 months ago by Igor Sheludko
Modified:
4 years, 6 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] An easier way of defining a stub call interface descriptor. This CL introduces a DECLARE_DEFAULT_DESCRIPTOR macro that helps defining a CallInterfaceDescriptor in a cases where it is not important which registers to use for passing arguments. One can use such descriptors for new TurboFan stubs. HasPropertyDescriptor now uses the new machinery. Committed: https://crrev.com/a2fef3af4b3ba5e973ce56dd454b8c77f00a4897 Cr-Commit-Position: refs/heads/master@{#36675}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -27 lines) Patch
M src/arm/interface-descriptors-arm.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/interface-descriptors.h View 1 4 chunks +19 lines, -5 lines 0 comments Download
M src/interface-descriptors.cc View 1 2 chunks +1 line, -8 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/s390/interface-descriptors-s390.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 40 (24 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002143002/40001
4 years, 7 months ago (2016-05-23 17:29:12 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/14909)
4 years, 7 months ago (2016-05-23 17:34:58 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002143002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002143002/60001
4 years, 7 months ago (2016-05-23 19:08:23 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/6194) v8_linux64_rel_ng_triggered on ...
4 years, 7 months ago (2016-05-23 19:48:36 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002143002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002143002/100001
4 years, 7 months ago (2016-05-25 17:03:59 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/7769)
4 years, 7 months ago (2016-05-25 17:11:30 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002143002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002143002/120001
4 years, 7 months ago (2016-05-25 17:15:59 UTC) #24
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-25 17:55:10 UTC) #26
commit-bot: I haz the power
Dry run: None
4 years, 7 months ago (2016-05-25 17:55:18 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002143002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002143002/140001
4 years, 6 months ago (2016-05-30 13:21:52 UTC) #29
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-30 13:48:32 UTC) #31
Igor Sheludko
PTAL
4 years, 6 months ago (2016-05-30 15:08:59 UTC) #33
Toon Verwaest
lgtm nice
4 years, 6 months ago (2016-06-01 14:53:10 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002143002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002143002/140001
4 years, 6 months ago (2016-06-02 08:58:03 UTC) #36
commit-bot: I haz the power
Committed patchset #2 (id:140001)
4 years, 6 months ago (2016-06-02 09:25:55 UTC) #38
commit-bot: I haz the power
4 years, 6 months ago (2016-06-02 09:28:34 UTC) #40
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2fef3af4b3ba5e973ce56dd454b8c77f00a4897
Cr-Commit-Position: refs/heads/master@{#36675}

Powered by Google App Engine
This is Rietveld 408576698