Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2002113002: Heuristic optimization in expression classifiers (Closed)

Created:
4 years, 7 months ago by nickie
Modified:
4 years, 6 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@nickie-1708193003-class-rev
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Heuristic optimization in expression classifiers This patch optimizes a frequently occurring case, where a ArrowFormalParametersProduction error in the list is skipped and this forces all the remaining errors to be shifted left. Shifting is expensive and is avoided here, at the cost of (sometimes) wasting the slot of the ArrowFormalParametersProduction error in the list. It depends on https://codereview.chromium.org/1708193003, the patch that aims to reduce memory footprint of expression classifiers. R=rossberg@chromium.org BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M src/parsing/expression-classifier.h View 2 chunks +19 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 4 (1 generated)
rossberg
Lgtm, but you may want Adam's opinion, too. (Though he is away right now, so ...
4 years, 6 months ago (2016-05-30 13:00:08 UTC) #1
nickie
On 2016/05/30 13:00:08, rossberg wrote: > Lgtm, but you may want Adam's opinion, too. (Though ...
4 years, 6 months ago (2016-05-30 13:02:10 UTC) #2
nickie
4 years, 6 months ago (2016-06-10 16:40:22 UTC) #3
On 2016/05/30 13:02:10, nickie wrote:
> On 2016/05/30 13:00:08, rossberg wrote:
> > Lgtm, but you may want Adam's opinion, too. (Though he is away right now, so
> > maybe land it anyways. :) )
> 
> I'm still benchmarking this and a couple of other versions.  I'll let you and
> Adam know when this is ready.

This is abandoned, in favour of https://codereview.chromium.org/1708193003/

Powered by Google App Engine
This is Rietveld 408576698