Change "bool createdByParser" of createElement() to enum

third_party/WebKit/Source/core/dom/Document.h

Index: third_party/WebKit/Source/core/dom/Document.h
diff --git a/third_party/WebKit/Source/core/dom/Document.h b/third_party/WebKit/Source/core/dom/Document.h
index 2816210aa4d48655d719edabd21b46e1998617dd..bdb60e7dd9e24fab1094c4b67e2a2a2e6d75a53c 100644
--- a/third_party/WebKit/Source/core/dom/Document.h
+++ b/third_party/WebKit/Source/core/dom/Document.h
@@ -214,6 +214,14 @@ enum ShadowCascadeOrder {
     ShadowCascadeV1
 };
 
+enum CreateElementFlags {

[yosin_UTC9, 2016/05/24 08:53:53]

Is this bit flag? If not, please use |enum class| to allow forward declaration?

[kojii, 2016/05/24 09:49:14]

Yes, this is a bit flag.

[yosin_UTC9, 2016/05/25 01:32:52]

How about using |CreateRequester| or another good name to specify, parser,
createElement(), import, clone, etc? If so, we can close concept of sync/async
customer element creation in Customer Element module. It is hard to maintain or
review by remembering which one is sync/async.

The kludge we can use:

enum CreateRequester {
  ForSynchronousCustomElements = 1,
  ForAsynchronousCustomElements = 0,

  CreateByParser = SynchronousCustomElements,
  CreateByClone = AsynchronousCustomElements,
  CreateByImportNode = AsynchronousCustomElements,
  CreateByCreateElement = SynchronousCustomElements,
  ...
}

[kojii, 2016/05/25 04:11:45]

Done, added aliases.

The sync flag is added to the spec, and whenever the spec "create an element",
it specifies its value, so I think it's useful to set/unset directly without
relying on the requester.

However, there are some parts we don't have specs (editing! ;) so serving both
cases is a good idea.

I didn't add ImportNode because both cloneNode() and importNode() refer to the
"clone a node" concept:
https://dom.spec.whatwg.org/#concept-node-clone

+    CreatedByParser = 1 << 0,
+    // Synchronous custom elements flag
+    // https://dom.spec.whatwg.org/#concept-create-element
+    SynchronousCustomElements = 0,
+    AsynchronousCustomElements = 1 << 1,
+};
+
 using DocumentClassFlags = unsigned char;
 
 class CORE_EXPORT Document : public ContainerNode, public TreeScope, public SecurityContext, public ExecutionContext, public Supplementable<Document> {
@@ -292,7 +300,7 @@ public:
     Attr* createAttributeNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&, bool shouldIgnoreNamespaceChecks = false);
     Node* importNode(Node* importedNode, bool deep, ExceptionState&);
     Element* createElementNS(const AtomicString& namespaceURI, const AtomicString& qualifiedName, ExceptionState&);
-    Element* createElement(const QualifiedName&, bool createdByParser);
+    Element* createElement(const QualifiedName&, CreateElementFlags);
 
     Element* elementFromPoint(int x, int y) const;
     HeapVector<Member<Element>> elementsFromPoint(int x, int y) const;