Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
index 50ab02a43e01a3703a281b872ea2132efae050e7..05083b33efb769b9a57f209b99de7febbe887bd5 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp
@@ -17,7 +17,7 @@ namespace {
String16 findMagicComment(const String16& content, const String16& name, bool multiline, bool* deprecated)
{
- ASSERT(name.find("=") == kNotFound);
+ DCHECK(name.find("=") == kNotFound);
if (deprecated)
*deprecated = false;
@@ -60,8 +60,8 @@ String16 findMagicComment(const String16& content, const String16& name, bool mu
if (deprecated && content[pos + 2] == '@')
*deprecated = true;
- ASSERT(equalSignPos);
- ASSERT(!multiline || closingCommentPos);
+ DCHECK(equalSignPos);
+ DCHECK(!multiline || closingCommentPos);
size_t urlPos = equalSignPos + 1;
String16 match = multiline
? content.substring(urlPos, closingCommentPos - urlPos)
@@ -212,7 +212,7 @@ PassOwnPtr<protocol::Array<protocol::Debugger::SearchMatch>> searchInTextByLines
PassOwnPtr<protocol::Value> toProtocolValue(v8::Local<v8::Context> context, v8::Local<v8::Value> value, int maxDepth)
{
if (value.IsEmpty()) {
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}
@@ -273,7 +273,7 @@ PassOwnPtr<protocol::Value> toProtocolValue(v8::Local<v8::Context> context, v8::
}
return std::move(jsonObject);
}
- ASSERT_NOT_REACHED();
+ NOTREACHED();
return nullptr;
}

Powered by Google App Engine
This is Rietveld 408576698