Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
index 285bac4d4a02f95d2e12a61c95609c1252a7fb50..d7a3937c8e64b26d2682c49e23789224516de826 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp
@@ -38,7 +38,7 @@ V8StackTraceImpl::Frame toFrame(v8::Local<v8::StackFrame> frame)
void toFramesVector(v8::Local<v8::StackTrace> stackTrace, protocol::Vector<V8StackTraceImpl::Frame>& frames, size_t maxStackSize, v8::Isolate* isolate)
{
- ASSERT(isolate->InContext());
+ DCHECK(isolate->InContext());
int frameCount = stackTrace->GetFrameCount();
if (frameCount > static_cast<int>(maxStackSize))
frameCount = maxStackSize;
@@ -154,31 +154,31 @@ V8StackTraceImpl::~V8StackTraceImpl()
String16 V8StackTraceImpl::topSourceURL() const
{
- ASSERT(m_frames.size());
+ DCHECK(m_frames.size());
return m_frames[0].m_scriptName;
}
int V8StackTraceImpl::topLineNumber() const
{
- ASSERT(m_frames.size());
+ DCHECK(m_frames.size());
return m_frames[0].m_lineNumber;
}
int V8StackTraceImpl::topColumnNumber() const
{
- ASSERT(m_frames.size());
+ DCHECK(m_frames.size());
return m_frames[0].m_columnNumber;
}
String16 V8StackTraceImpl::topFunctionName() const
{
- ASSERT(m_frames.size());
+ DCHECK(m_frames.size());
return m_frames[0].m_functionName;
}
String16 V8StackTraceImpl::topScriptId() const
{
- ASSERT(m_frames.size());
+ DCHECK(m_frames.size());
return m_frames[0].m_scriptId;
}

Powered by Google App Engine
This is Rietveld 408576698