third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp - Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/inspector_protocol/CollectionsWTF.h ('K') | « third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InjectedScriptHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

index 4323af3d0a987212e8fad6023bdb756808d6bf2e..77e4abc54eb6734b4828eab98d914fb2d9eb31c3 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp

@@ -126,13 +126,13 @@ public:

WriteResult WriteAsciiChunk(char* data, int size) override

{

- ASSERT(false);

+ DCHECK(false);

return kAbort;

}

WriteResult WriteHeapStatsChunk(v8::HeapStatsUpdate* updateData, int count) override

{

- ASSERT(count > 0);

+ DCHECK_GT(count, 0);

OwnPtr<protocol::Array<int>> statsDiff = protocol::Array<int>::create();

for (int i = 0; i < count; ++i) {

statsDiff->addItem(updateData[i].index);

@@ -164,7 +164,7 @@ void V8HeapProfilerAgentImpl::clearFrontend()

{

ErrorString error;

disable(&error);

- ASSERT(m_frontend);

+ DCHECK(m_frontend);

m_frontend = nullptr;

}