Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1855)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp

Issue 2001893002: DevTools: expose raw pointers in protocol collections, s/ASSERT/DCHECK/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
index 02b29a1cd201e33364a3a1edbbf3f41a9fc3c9d7..b8dbf73f7d64fd0626506ee6fbcfa3d408a9740e 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp
@@ -88,7 +88,7 @@ PassOwnPtr<InjectedScript> InjectedScript::create(InspectedContext* inspectedCon
v8::Local<v8::Value> value;
if (!inspectedContext->debugger()->compileAndRunInternalScript(context, toV8String(isolate, injectedScriptSource)).ToLocal(&value))
return nullptr;
- ASSERT(value->IsFunction());
+ DCHECK(value->IsFunction());
v8::Local<v8::Function> function = v8::Local<v8::Function>::Cast(value);
v8::Local<v8::Object> windowGlobal = context->Global();
v8::Local<v8::Value> info[] = { scriptHostWrapper, windowGlobal, v8::Number::New(isolate, inspectedContext->contextId()) };
@@ -268,7 +268,7 @@ void InjectedScript::setCustomObjectFormatterEnabled(bool enabled)
function.appendArgument(enabled);
bool hadException = false;
function.call(hadException);
- ASSERT(!hadException);
+ DCHECK(!hadException);
}
bool InjectedScript::canAccessInspectedWindow() const
@@ -429,7 +429,7 @@ bool InjectedScript::Scope::installCommandLineAPI()
void InjectedScript::Scope::ignoreExceptionsAndMuteConsole()
{
- ASSERT(!m_ignoreExceptionsAndMuteConsole);
+ DCHECK(!m_ignoreExceptionsAndMuteConsole);
m_ignoreExceptionsAndMuteConsole = true;
m_debugger->client()->muteConsole();
m_previousPauseOnExceptionsState = setPauseOnExceptionsState(V8DebuggerImpl::DontPauseOnExceptions);
@@ -447,7 +447,7 @@ V8DebuggerImpl::PauseOnExceptionsState InjectedScript::Scope::setPauseOnExceptio
void InjectedScript::Scope::pretendUserGesture()
{
- ASSERT(!m_userGesture);
+ DCHECK(!m_userGesture);
m_userGesture = true;
m_debugger->client()->beginUserGesture();
}
@@ -456,7 +456,7 @@ void InjectedScript::Scope::cleanup()
{
v8::Local<v8::Object> global;
if (m_global.ToLocal(&global)) {
- ASSERT(!m_context.IsEmpty());
+ DCHECK(!m_context.IsEmpty());
global->DeletePrivate(m_context, m_extensionPrivate);
m_global = v8::MaybeLocal<v8::Object>();
}

Powered by Google App Engine
This is Rietveld 408576698