Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Issue 2001783003: Get rid of CPDF_Object::GetArray(). (Closed)

Created:
4 years, 7 months ago by Lei Zhang
Modified:
4 years, 7 months ago
Reviewers:
Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -170 lines) Patch
M core/fpdfapi/fpdf_page/fpdf_page_parser.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_array.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp View 1 2 8 chunks +17 lines, -17 lines 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_array.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_parser/include/cpdf_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/fpdfdoc/cpvt_generateap.cpp View 1 2 chunks +8 lines, -14 lines 0 comments Download
M core/fpdfdoc/doc_formfield.cpp View 1 chunk +16 lines, -35 lines 0 comments Download
M fpdfsdk/fpdfsave.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M fpdfsdk/fpdfxfa/fpdfxfa_doc.cpp View 2 chunks +69 lines, -76 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Lei Zhang
4 years, 7 months ago (2016-05-21 02:35:15 UTC) #3
Wei Li
lgtm
4 years, 7 months ago (2016-05-21 05:19:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001783003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001783003/40001
4 years, 7 months ago (2016-05-22 03:51:53 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-22 04:08:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/b8bf55f73390a9460ec13dbffcf5d22819f9...

Powered by Google App Engine
This is Rietveld 408576698