Get rid of CPDF_Object::GetArray().

core/fpdfapi/fpdf_parser/cpdf_object_unittest.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/fpdfapi/fpdf_parser/cpdf_boolean.h"
 #include "core/fpdfapi/fpdf_parser/cpdf_null.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_array.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_dictionary.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_name.h"
 #include "core/fpdfapi/fpdf_parser/include/cpdf_number.h"
@@ skipping 165 matching lines @@
   std::vector<ScopedObj> m_DirectObjs;
   std::vector<int> m_DirectObjTypes;
   std::vector<ScopedObj> m_RefObjs;
   CPDF_Dictionary* m_DictObj;
   CPDF_Dictionary* m_StreamDictObj;
   CPDF_Array* m_ArrayObj;
   std::vector<CPDF_Object*> m_IndirectObjs;
 };
 
 TEST_F(PDFObjectsTest, GetString) {
-  const char* direct_obj_results[] = {
+  const char* const direct_obj_results[] = {
       "false", "true", "1245", "9.00345", "A simple test", "\t\n", "space",
       "",      "",     "",     ""};
   // Check for direct objects.
   for (size_t i = 0; i < m_DirectObjs.size(); ++i)
     EXPECT_STREQ(direct_obj_results[i], m_DirectObjs[i]->GetString().c_str());
 
   // Check indirect references.
-  const char* indirect_obj_results[] = {"true", "1245", "\t\n", "space",
-                                        "",     "",     ""};
+  const char* const indirect_obj_results[] = {"true", "1245", "\t\n", "space",
+                                              "",     "",     ""};
   for (size_t i = 0; i < m_RefObjs.size(); ++i) {
     EXPECT_STREQ(indirect_obj_results[i], m_RefObjs[i]->GetString().c_str());
   }
 }
 
 TEST_F(PDFObjectsTest, GetUnicodeText) {
-  const wchar_t* direct_obj_results[] = {
+  const wchar_t* const direct_obj_results[] = {
       L"",     L"",      L"", L"", L"A simple test",
       L"\t\n", L"space", L"", L"", L"abcdefghijklmnopqrstuvwxyz",
       L""};
   // Check for direct objects.
   for (size_t i = 0; i < m_DirectObjs.size(); ++i) {
     EXPECT_STREQ(direct_obj_results[i],
                  m_DirectObjs[i]->GetUnicodeText().c_str());
   }
 
   // Check indirect references.
@@ skipping 20 matching lines @@
   for (size_t i = 0; i < m_DirectObjs.size(); ++i)
     EXPECT_EQ(direct_obj_results[i], m_DirectObjs[i]->GetInteger());
 
   // Check indirect references.
   const int indirect_obj_results[] = {1, 1245, 0, 0, 0, 0, 0};
   for (size_t i = 0; i < m_RefObjs.size(); ++i)
     EXPECT_EQ(indirect_obj_results[i], m_RefObjs[i]->GetInteger());
 }
 
 TEST_F(PDFObjectsTest, GetDict) {
-  const CPDF_Dictionary* direct_obj_results[] = {
+  const CPDF_Dictionary* const direct_obj_results[] = {
       nullptr, nullptr, nullptr,   nullptr,         nullptr, nullptr,
       nullptr, nullptr, m_DictObj, m_StreamDictObj, nullptr};
   // Check for direct objects.
   for (size_t i = 0; i < m_DirectObjs.size(); ++i)
     EXPECT_EQ(direct_obj_results[i], m_DirectObjs[i]->GetDict());
 
   // Check indirect references.
-  const CPDF_Dictionary* indirect_obj_results[] = {
+  const CPDF_Dictionary* const indirect_obj_results[] = {
       nullptr, nullptr, nullptr, nullptr, nullptr, m_DictObj, m_StreamDictObj};
   for (size_t i = 0; i < m_RefObjs.size(); ++i)
     EXPECT_EQ(indirect_obj_results[i], m_RefObjs[i]->GetDict());
 }
 
 TEST_F(PDFObjectsTest, GetArray) {
-  const CPDF_Array* direct_obj_results[] = {
+  const CPDF_Array* const direct_obj_results[] = {
       nullptr, nullptr,    nullptr, nullptr, nullptr, nullptr,
       nullptr, m_ArrayObj, nullptr, nullptr, nullptr};
   // Check for direct objects.
   for (size_t i = 0; i < m_DirectObjs.size(); ++i)
-    EXPECT_EQ(direct_obj_results[i], m_DirectObjs[i]->GetArray());
+    EXPECT_EQ(direct_obj_results[i], m_DirectObjs[i]->AsArray());
 
   // Check indirect references.
   for (const auto& it : m_RefObjs)
-    EXPECT_EQ(nullptr, it->GetArray());
+    EXPECT_EQ(nullptr, it->AsArray());
 }
 
 TEST_F(PDFObjectsTest, Clone) {
   // Check for direct objects.
   for (size_t i = 0; i < m_DirectObjs.size(); ++i) {
     ScopedObj obj(m_DirectObjs[i]->Clone());
     EXPECT_TRUE(Equal(m_DirectObjs[i].get(), obj.get()));
   }
 
   // Check indirect references.
@@ skipping 20 matching lines @@
 
   // Check indirect references.
   for (size_t i = 0; i < m_RefObjs.size(); ++i)
     EXPECT_EQ(m_IndirectObjs[i], m_RefObjs[i]->GetDirect());
 }
 
 TEST_F(PDFObjectsTest, SetString) {
   // Check for direct objects.
   const char* const set_values[] = {"true",    "fake", "3.125f", "097",
                                     "changed", "",     "NewName"};
-  const char* expected[] = {"true",    "false", "3.125",  "97",
-                            "changed", "",      "NewName"};
+  const char* const expected[] = {"true",    "false", "3.125",  "97",
+                                  "changed", "",      "NewName"};
   for (size_t i = 0; i < FX_ArraySize(set_values); ++i) {
     m_DirectObjs[i]->SetString(set_values[i]);
     EXPECT_STREQ(expected[i], m_DirectObjs[i]->GetString().c_str());
   }
 }
 
 TEST_F(PDFObjectsTest, IsTypeAndAsType) {
   // Check for direct objects.
   for (size_t i = 0; i < m_DirectObjs.size(); ++i) {
     if (m_DirectObjTypes[i] == CPDF_Object::ARRAY) {
@@ skipping 97 matching lines @@
     EXPECT_EQ(rect.left, arr_rect.left);
     EXPECT_EQ(rect.right, arr_rect.right);
     EXPECT_EQ(rect.bottom, arr_rect.bottom);
     EXPECT_EQ(rect.top, arr_rect.top);
   }
 }
 
 TEST(PDFArrayTest, GetTypeAt) {
   {
     // Boolean array.
-    bool vals[] = {true, false, false, true, true};
+    const bool vals[] = {true, false, false, true, true};
     ScopedArray arr(new CPDF_Array);
     for (size_t i = 0; i < FX_ArraySize(vals); ++i)
       arr->InsertAt(i, new CPDF_Boolean(vals[i]));
     for (size_t i = 0; i < FX_ArraySize(vals); ++i) {
       TestArrayAccessors(arr.get(), i,                // Array and index.
                          vals[i] ? "true" : "false",  // String value.
                          nullptr,                     // Const string value.
                          vals[i] ? 1 : 0,             // Integer value.
                          0,                           // Float value.
                          nullptr,                     // Array value.
                          nullptr,                     // Dictionary value.
                          nullptr);                    // Stream value.
     }
   }
   {
     // Integer array.
-    int vals[] = {10, 0, -345, 2089345456, -1000000000, 567, 93658767};
+    const int vals[] = {10, 0, -345, 2089345456, -1000000000, 567, 93658767};
     ScopedArray arr(new CPDF_Array);
     for (size_t i = 0; i < FX_ArraySize(vals); ++i)
       arr->InsertAt(i, new CPDF_Number(vals[i]));
     for (size_t i = 0; i < FX_ArraySize(vals); ++i) {
       char buf[33];
       TestArrayAccessors(arr.get(), i,                  // Array and index.
                          FXSYS_itoa(vals[i], buf, 10),  // String value.
                          nullptr,                       // Const string value.
                          vals[i],                       // Integer value.
                          vals[i],                       // Float value.
                          nullptr,                       // Array value.
                          nullptr,                       // Dictionary value.
                          nullptr);                      // Stream value.
     }
   }
   {
     // Float array.
-    float vals[] = {0.0f,    0,     10,    10.0f,   0.0345f,
-                    897.34f, -2.5f, -1.0f, -345.0f, -0.0f};
-    const char* expected_str[] = {"0",      "0",    "10", "10",   "0.0345",
-                                  "897.34", "-2.5", "-1", "-345", "0"};
+    const float vals[] = {0.0f,    0,     10,    10.0f,   0.0345f,
+                          897.34f, -2.5f, -1.0f, -345.0f, -0.0f};
+    const char* const expected_str[] = {
+        "0", "0", "10", "10", "0.0345", "897.34", "-2.5", "-1", "-345", "0"};
     ScopedArray arr(new CPDF_Array);
     for (size_t i = 0; i < FX_ArraySize(vals); ++i) {
       arr->InsertAt(i, new CPDF_Number(vals[i]));
     }
     for (size_t i = 0; i < FX_ArraySize(vals); ++i) {
       TestArrayAccessors(arr.get(), i,     // Array and index.
                          expected_str[i],  // String value.
                          nullptr,          // Const string value.
                          vals[i],          // Integer value.
                          vals[i],          // Float value.
@@ skipping 260 matching lines @@
   EXPECT_EQ(arr->GetCount(), arr1->GetCount());
   for (size_t i = 0; i < arr->GetCount(); ++i) {
     EXPECT_EQ(CPDF_Object::REFERENCE, arr->GetObjectAt(i)->GetType());
     EXPECT_EQ(indirect_objs[i], arr->GetObjectAt(i)->GetDirect());
     EXPECT_EQ(indirect_objs[i], arr->GetDirectObjectAt(i));
     EXPECT_EQ(CPDF_Object::REFERENCE, arr1->GetObjectAt(i)->GetType());
     EXPECT_EQ(indirect_objs[i], arr1->GetObjectAt(i)->GetDirect());
     EXPECT_EQ(indirect_objs[i], arr1->GetDirectObjectAt(i));
   }
 }