Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2001753003: Avoid duplication of HARMONY_STAGED flags due to no-i18n build (Closed)

Created:
4 years, 7 months ago by adamk
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Avoid duplication of HARMONY_STAGED flags due to no-i18n build Instead of having two lists of harmony flags, one with i18n and one without, use a bit more macro programming. Committed: https://crrev.com/bb8b2b9b029c1faced71321516a571d7e8992e0c Cr-Commit-Position: refs/heads/master@{#36450}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -11 lines) Patch
M src/flag-definitions.h View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
adamk
4 years, 7 months ago (2016-05-21 00:05:01 UTC) #2
adamk
Tested the noi18n build locally.
4 years, 7 months ago (2016-05-21 00:07:33 UTC) #3
jungshik at Google
LGTM ! Thanks a lot !
4 years, 7 months ago (2016-05-21 00:10:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001753003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001753003/1
4 years, 7 months ago (2016-05-23 18:05:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 18:39:31 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 18:40:46 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb8b2b9b029c1faced71321516a571d7e8992e0c
Cr-Commit-Position: refs/heads/master@{#36450}

Powered by Google App Engine
This is Rietveld 408576698