Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: src/flag-definitions.h

Issue 2001753003: Avoid duplication of HARMONY_STAGED flags due to no-i18n build (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/flag-definitions.h
diff --git a/src/flag-definitions.h b/src/flag-definitions.h
index 90919761c939dd9185c32fd08b19dfa88ee24224..8d09a92befeef8ee5fdd12fe9462b779bc5adf49 100644
--- a/src/flag-definitions.h
+++ b/src/flag-definitions.h
@@ -206,25 +206,21 @@ DEFINE_IMPLICATION(es_staging, move_object_start)
V(harmony_async_await, "harmony async-await")
// Features that are complete (but still behind --harmony/es-staging flag).
-#ifdef V8_I18N_SUPPORT
-#define HARMONY_STAGED(V) \
+#define HARMONY_STAGED_BASE(V) \
V(harmony_regexp_lookbehind, "harmony regexp lookbehind") \
V(harmony_tailcalls, "harmony tail calls") \
V(harmony_explicit_tailcalls, "harmony explicit tail calls") \
V(harmony_object_values_entries, "harmony Object.values / Object.entries") \
V(harmony_object_own_property_descriptors, \
"harmony Object.getOwnPropertyDescriptors()") \
- V(harmony_string_padding, "harmony String-padding methods") \
+ V(harmony_string_padding, "harmony String-padding methods")
+
+#ifdef V8_I18N_SUPPORT
+#define HARMONY_STAGED(V) \
+ HARMONY_STAGED_BASE(V) \
V(icu_case_mapping, "case mapping with ICU rather than Unibrow")
#else
-#define HARMONY_STAGED(V) \
- V(harmony_regexp_lookbehind, "harmony regexp lookbehind") \
- V(harmony_tailcalls, "harmony tail calls") \
- V(harmony_explicit_tailcalls, "harmony explicit tail calls") \
- V(harmony_object_values_entries, "harmony Object.values / Object.entries") \
- V(harmony_object_own_property_descriptors, \
- "harmony Object.getOwnPropertyDescriptors()") \
- V(harmony_string_padding, "harmony String-padding methods")
+#define HARMONY_STAGED(V) HARMONY_STAGED_BASE(V)
#endif
// Features that are shipping (turned on by default, but internal flag remains).
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698