Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 2001533002: Clear DeferredTaskHandler's audio thread ID upon the thread going away. (Closed)

Created:
4 years, 7 months ago by sof
Modified:
4 years, 7 months ago
Reviewers:
Raymond Toy, hongchan
CC:
Raymond Toy, blink-reviews, chromium-reviews, haraken, hongchan
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clear DeferredTaskHandler's audio thread ID upon the thread going away. Tracking the thread ID of the (current) audio thread is needed to both sanity check that code paths and methods are performed on the expected thread, and ensure safe operation. In the rare cases where the recorded audio thread is stopped and terminated by the embedder, first clear out the associated thread ID. This is needed should a new thread be subsequently created. R= BUG=612127 Committed: https://crrev.com/78df581f4e3be4387721661f592026bf92bcd58c Cr-Commit-Position: refs/heads/master@{#395182}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M third_party/WebKit/Source/modules/webaudio/AbstractAudioContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioContext.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/DeferredTaskHandler.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sof
please take a look.
4 years, 7 months ago (2016-05-20 08:15:07 UTC) #2
Raymond Toy
lgtm
4 years, 7 months ago (2016-05-20 14:08:58 UTC) #3
hongchan
lgtm
4 years, 7 months ago (2016-05-20 14:12:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001533002/1
4 years, 7 months ago (2016-05-20 20:32:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 22:22:03 UTC) #7
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 22:25:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78df581f4e3be4387721661f592026bf92bcd58c
Cr-Commit-Position: refs/heads/master@{#395182}

Powered by Google App Engine
This is Rietveld 408576698