Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/features.gni

Issue 2001523002: GYP changes for arm64 linux build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add GN Build changes + Incorporate review comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build/config/allocator.gni ('K') | « build/config/compiler/BUILD.gn ('k') | build/config/sysroot.gni » ('j') | third_party/libwebp/README.chromium » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/features.gni
diff --git a/build/config/features.gni b/build/config/features.gni
index e1c8847f25bbde7175f77954ce27b9fb4f138f5d..e1a9cf897559ebfae317d5de95a061bd0571bcb0 100644
--- a/build/config/features.gni
+++ b/build/config/features.gni
@@ -30,8 +30,8 @@ declare_args() {
# Enables Native Client support.
# TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion.
- enable_nacl =
- !is_ios && !is_android && !is_chromecast && current_cpu != "mipsel"
+ enable_nacl = !is_ios && !is_android && !is_chromecast &&
+ current_cpu != "mipsel" && !(is_linux && target_cpu == "arm64")
Nico 2016/06/04 01:18:24 add a comment here too
apatole 2016/06/06 06:40:00 Done.
# If debug_devtools is set to true, JavaScript files for DevTools are stored
# as is and loaded from disk. Otherwise, a concatenated file is stored in
« build/config/allocator.gni ('K') | « build/config/compiler/BUILD.gn ('k') | build/config/sysroot.gni » ('j') | third_party/libwebp/README.chromium » ('J')

Powered by Google App Engine
This is Rietveld 408576698