WebGL: WebGLObject is non-copyable

WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55
Cr-Commit-Position: refs/heads/master@{#418471}

[Eric Willigers, 2016-05-20 06:08:44]

Description was changed from

==========
WebGL: WebGLRenderingContextBase is non-copyable

WebGLRenderingContextBase and WebGLVertexArrayObjectBase
are now declared non-copyable

BUG=613450
R=bajones@chromium.org
==========

to

==========
WebGL: WebGLRenderingContextBase is non-copyable

WebGLRenderingContextBase and WebGLVertexArrayObjectBase
are now declared non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Eric Willigers, 2016-05-20 06:09:36]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 06:09:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001503002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001503002/1

[commit-bot: I haz the power, 2016-05-20 08:24:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 08:24:45]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-07-11 04:39:30]

ericwilligers@chromium.org changed reviewers:
+ kbr@chromium.org
- bajones@chromium.org

[Eric Willigers, 2016-09-01 01:52:12]

ericwilligers@chromium.org changed reviewers:
+ zmo@chromium.org

[Ken Russell (switch to Gerrit), 2016-09-01 05:43:33]

https://codereview.chromium.org/2001503002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
(right):

https://codereview.chromium.org/2001503002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h:16:
WTF_MAKE_NONCOPYABLE(WebGLVertexArrayObjectBase);
It seems arbitrary to make just this WebGLObject type non-copyable. Why not make
the base class, WebGLObject, non-copyable?

[Eric Willigers, 2016-09-01 06:02:07]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 06:02:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 06:02:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 06:02:19]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-01 06:02:26]

https://codereview.chromium.org/2001503002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h
(right):

https://codereview.chromium.org/2001503002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h:16:
WTF_MAKE_NONCOPYABLE(WebGLVertexArrayObjectBase);
On 2016/09/01 05:43:33, Ken Russell wrote:
> It seems arbitrary to make just this WebGLObject type non-copyable. Why not
make
> the base class, WebGLObject, non-copyable?

Done. I think I was looking at classes that held vectors. I missed
WebGLFramebuffer, which becomes non-copyable as it indirectly inherits from
WebGLObject.

[Eric Willigers, 2016-09-01 06:03:42]

Description was changed from

==========
WebGL: WebGLRenderingContextBase is non-copyable

WebGLRenderingContextBase and WebGLVertexArrayObjectBase
are now declared non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2016-09-01 21:27:59]

LGTM

If you're still making changes against http://crbug.com/613450 then it should be
in the Started state, not in the Fixed state.

[Eric Willigers, 2016-09-01 23:57:00]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:57:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 23:57:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 23:57:25]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-02 00:42:46]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 00:43:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:43:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:43:07]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-02 00:46:34]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 00:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 00:46:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 00:46:50]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-13 02:50:27]

The CQ bit was checked by ericwilligers@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 02:50:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 02:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 02:50:52]

Dry run: Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-13 07:18:00]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-09-13 07:18:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 07:18:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 07:18:22]

Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-13 09:05:18]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-09-13 09:05:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 09:05:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 09:05:40]

Your CL was about to rely on recently removed CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is no longer supported:
     tryserver.chromium.mac
     tryserver.chromium.win
   For more details, see http://crbug.com/617627.

[Eric Willigers, 2016-09-14 01:03:52]

Description was changed from

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Eric Willigers, 2016-09-14 01:04:01]

The CQ bit was checked by ericwilligers@chromium.org

[commit-bot: I haz the power, 2016-09-14 01:04:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 03:10:16]

Description was changed from

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-09-14 03:10:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-14 03:13:48]

Description was changed from

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
WebGL: WebGLObject is non-copyable

WebGLExtension, WebGLObject and WebGLRenderingContextBase are now declared
non-copyable

BUG=613450
R=bajones@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55
Cr-Commit-Position: refs/heads/master@{#418471}
==========

[commit-bot: I haz the power, 2016-09-14 03:13:49]

Patchset 2 (id:??) landed as
https://crrev.com/13e4f029fe21cda3df12bb34eb0b9f1e516c8d55
Cr-Commit-Position: refs/heads/master@{#418471}