Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObjectBase.h

Issue 2001503002: WebGL: WebGLObject is non-copyable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGLVertexArrayObjectBase_h 5 #ifndef WebGLVertexArrayObjectBase_h
6 #define WebGLVertexArrayObjectBase_h 6 #define WebGLVertexArrayObjectBase_h
7 7
8 #include "bindings/core/v8/ScopedPersistent.h" 8 #include "bindings/core/v8/ScopedPersistent.h"
9 #include "modules/webgl/WebGLBuffer.h" 9 #include "modules/webgl/WebGLBuffer.h"
10 #include "modules/webgl/WebGLContextObject.h" 10 #include "modules/webgl/WebGLContextObject.h"
11 #include "platform/heap/Handle.h" 11 #include "platform/heap/Handle.h"
12 12
13 namespace blink { 13 namespace blink {
14 14
15 class WebGLVertexArrayObjectBase : public WebGLContextObject { 15 class WebGLVertexArrayObjectBase : public WebGLContextObject {
16 WTF_MAKE_NONCOPYABLE(WebGLVertexArrayObjectBase);
Ken Russell (switch to Gerrit) 2016/09/01 05:43:33 It seems arbitrary to make just this WebGLObject t
Eric Willigers 2016/09/01 06:02:26 Done. I think I was looking at classes that held v
16 public: 17 public:
17 enum VaoType { 18 enum VaoType {
18 VaoTypeDefault, 19 VaoTypeDefault,
19 VaoTypeUser, 20 VaoTypeUser,
20 }; 21 };
21 22
22 ~WebGLVertexArrayObjectBase() override; 23 ~WebGLVertexArrayObjectBase() override;
23 24
24 GLuint object() const { return m_object; } 25 GLuint object() const { return m_object; }
25 26
(...skipping 30 matching lines...) Expand all
56 HeapVector<Member<WebGLBuffer>> m_arrayBufferList; 57 HeapVector<Member<WebGLBuffer>> m_arrayBufferList;
57 58
58 // For preserving the wrappers of WebGLBuffer objects latched in 59 // For preserving the wrappers of WebGLBuffer objects latched in
59 // via vertexAttribPointer calls. 60 // via vertexAttribPointer calls.
60 ScopedPersistent<v8::Array> m_arrayBufferWrappers; 61 ScopedPersistent<v8::Array> m_arrayBufferWrappers;
61 }; 62 };
62 63
63 } // namespace blink 64 } // namespace blink
64 65
65 #endif // WebGLVertexArrayObjectBase_h 66 #endif // WebGLVertexArrayObjectBase_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698