Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2001493002: Update union conversion algorithm (Closed)

Created:
4 years, 7 months ago by bashi
Modified:
4 years, 7 months ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update union conversion algorithm The algorithm[1] is updated to fix a bug on distinguishing dictionary and sequence<T>[2]. Update our implementation. [1] https://heycam.github.io/webidl/#es-union [2] https://github.com/heycam/webidl/issues/123 Committed: https://crrev.com/b81bc587695645f362434a4599241db2efe8ad32 Cr-Commit-Position: refs/heads/master@{#395297}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : Remove tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -28 lines) Patch
M third_party/WebKit/Source/bindings/templates/union_container.cpp View 1 2 3 9 chunks +31 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
bashi
PTAL? https://codereview.chromium.org/2001493002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/idl-union-type-unittest.html File third_party/WebKit/LayoutTests/fast/dom/idl-union-type-unittest.html (right): https://codereview.chromium.org/2001493002/diff/20001/third_party/WebKit/LayoutTests/fast/dom/idl-union-type-unittest.html#newcode159 third_party/WebKit/LayoutTests/fast/dom/idl-union-type-unittest.html:159: I'll remove blank lines.
4 years, 7 months ago (2016-05-20 06:44:16 UTC) #3
Yuki
LGTM.
4 years, 7 months ago (2016-05-20 06:53:48 UTC) #4
haraken
LGTM
4 years, 7 months ago (2016-05-20 07:25:06 UTC) #5
bashi
Chatted with tasak@ on how to fix link errors on Win. tasak@ found that we ...
4 years, 7 months ago (2016-05-23 05:36:03 UTC) #6
Yuki
On 2016/05/23 05:36:03, bashi1 wrote: > Chatted with tasak@ on how to fix link errors ...
4 years, 7 months ago (2016-05-23 05:43:27 UTC) #7
bashi
On 2016/05/23 05:43:27, Yuki wrote: > On 2016/05/23 05:36:03, bashi1 wrote: > > Chatted with ...
4 years, 7 months ago (2016-05-23 06:14:11 UTC) #8
Yuki
On 2016/05/23 06:14:11, bashi1 wrote: > On 2016/05/23 05:43:27, Yuki wrote: > > On 2016/05/23 ...
4 years, 7 months ago (2016-05-23 06:33:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001493002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001493002/60001
4 years, 7 months ago (2016-05-23 08:57:48 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 7 months ago (2016-05-23 09:52:07 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 09:53:21 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/b81bc587695645f362434a4599241db2efe8ad32
Cr-Commit-Position: refs/heads/master@{#395297}

Powered by Google App Engine
This is Rietveld 408576698