Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2003)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp

Issue 2001493002: Update union conversion algorithm (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/templates/union_container.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
index f0bca72bab76295bb8186127cdf9d693af977ab5..23fc4cf8f4c45b396bcdd8151738c2fa709729d0 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/LongOrTestDictionary.cpp
@@ -74,7 +74,16 @@ void V8LongOrTestDictionary::toImpl(v8::Isolate* isolate, v8::Local<v8::Value> v
if (conversionMode == UnionTypeConversionMode::Nullable && isUndefinedOrNull(v8Value))
return;
- if (isUndefinedOrNull(v8Value) || (v8Value->IsObject() && !v8Value->IsArray())) {
+ if (isUndefinedOrNull(v8Value)) {
+ TestDictionary cppValue;
+ V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState);
+ if (exceptionState.hadException())
+ return;
+ impl.setTestDictionary(cppValue);
+ return;
+ }
+
+ if (v8Value->IsObject()) {
TestDictionary cppValue;
V8TestDictionary::toImpl(isolate, v8Value, cppValue, exceptionState);
if (exceptionState.hadException())
« no previous file with comments | « third_party/WebKit/Source/bindings/templates/union_container.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698