third_party/WebKit/Source/config.gni - Issue 2001323002: Fix some TODO(GYP) in the GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/config.gni

Issue 2001323002: Fix some TODO(GYP) in the GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/config.gni

diff --git a/third_party/WebKit/Source/config.gni b/third_party/WebKit/Source/config.gni

index 914dadd0322459f1f16201271cf307071b24a7ee..17952b739c2dfa6ec60fbbd66189678e3edad957 100644

--- a/third_party/WebKit/Source/config.gni

+++ b/third_party/WebKit/Source/config.gni

@@ -52,8 +52,6 @@ feature_defines_list = [

]

if (is_debug) {

- # TODO(GYP) this should also be set when release_valgrind_build is set,

brettw 2016/05/23 22:06:26 Valgrind is gone.

- # but we don't have that flag in the GN build yet.

feature_defines_list += [ "WTF_USE_DYNAMIC_ANNOTATIONS=1" ]

}