Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 200113003: Fixed modulo by a power of 2 on A64. (Closed)

Created:
6 years, 9 months ago by Sven Panne
Modified:
6 years, 9 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Fixed modulo by a power of 2 on A64. Actually setting flags before checking them might be a good idea... :-/ R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/a64/lithium-codegen-a64.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 9 months ago (2014-03-14 10:17:02 UTC) #1
Benedikt Meurer
LGTM
6 years, 9 months ago (2014-03-14 10:18:22 UTC) #2
Sven Panne
6 years, 9 months ago (2014-03-14 10:19:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19924 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698