Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Side by Side Diff: src/a64/lithium-codegen-a64.cc

Issue 200113003: Fixed modulo by a power of 2 on A64. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4121 matching lines...) Expand 10 before | Expand all | Expand 10 after
4132 // version performs better. 4132 // version performs better.
4133 HMod* hmod = instr->hydrogen(); 4133 HMod* hmod = instr->hydrogen();
4134 int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1); 4134 int32_t mask = divisor < 0 ? -(divisor + 1) : (divisor - 1);
4135 Label dividend_is_not_negative, done; 4135 Label dividend_is_not_negative, done;
4136 if (hmod->CheckFlag(HValue::kLeftCanBeNegative)) { 4136 if (hmod->CheckFlag(HValue::kLeftCanBeNegative)) {
4137 __ Cmp(dividend, 0); 4137 __ Cmp(dividend, 0);
4138 __ B(pl, &dividend_is_not_negative); 4138 __ B(pl, &dividend_is_not_negative);
4139 // Note that this is correct even for kMinInt operands. 4139 // Note that this is correct even for kMinInt operands.
4140 __ Neg(dividend, dividend); 4140 __ Neg(dividend, dividend);
4141 __ And(dividend, dividend, Operand(mask)); 4141 __ And(dividend, dividend, Operand(mask));
4142 __ Neg(dividend, dividend); 4142 __ Negs(dividend, dividend);
4143 if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) { 4143 if (hmod->CheckFlag(HValue::kBailoutOnMinusZero)) {
4144 DeoptimizeIf(eq, instr->environment()); 4144 DeoptimizeIf(eq, instr->environment());
4145 } 4145 }
4146 __ B(&done); 4146 __ B(&done);
4147 } 4147 }
4148 4148
4149 __ bind(&dividend_is_not_negative); 4149 __ bind(&dividend_is_not_negative);
4150 __ And(dividend, dividend, Operand(mask)); 4150 __ And(dividend, dividend, Operand(mask));
4151 __ bind(&done); 4151 __ bind(&done);
4152 } 4152 }
(...skipping 1683 matching lines...) Expand 10 before | Expand all | Expand 10 after
5836 __ Bind(&out_of_object); 5836 __ Bind(&out_of_object);
5837 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset)); 5837 __ Ldr(result, FieldMemOperand(object, JSObject::kPropertiesOffset));
5838 // Index is equal to negated out of object property index plus 1. 5838 // Index is equal to negated out of object property index plus 1.
5839 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2)); 5839 __ Sub(result, result, Operand::UntagSmiAndScale(index, kPointerSizeLog2));
5840 __ Ldr(result, FieldMemOperand(result, 5840 __ Ldr(result, FieldMemOperand(result,
5841 FixedArray::kHeaderSize - kPointerSize)); 5841 FixedArray::kHeaderSize - kPointerSize));
5842 __ Bind(&done); 5842 __ Bind(&done);
5843 } 5843 }
5844 5844
5845 } } // namespace v8::internal 5845 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698