Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2001113002: [css-grid] Update <fixed-size> syntax (Closed)

Created:
4 years, 7 months ago by Manuel Rego
Modified:
4 years, 7 months ago
CC:
chromium-reviews, jfernandez, szager+layoutwatch_chromium.org, zoltan1, svillar, blink-reviews-css, pdr+renderingwatchlist_chromium.org, Manuel Rego, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, blink-reviews, eae+blinkwatch, blink-reviews-layout_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[css-grid] Update <fixed-size> syntax The syntax for <fixed-size> has been updated on the spec: https://drafts.csswg.org/css-grid/#typedef-fixed-size New syntax is: <fixed-size> = <fixed-breadth> | minmax( <fixed-breadth> , <track-breadth> ) | minmax( <inflexible-breadth> , <fixed-breadth> ) This means that it's enough to have one <fixed-breadth>, it doesn't matter if it's as minimum or maximum. Before it was required that the minimum was fixed. Updated test to check the new expected behavior. BUG=611412 TEST=fast/css-grid-layout/grid-element-auto-repeat-get-set.html Committed: https://crrev.com/e41b40417c0ba7a1f44a0cb6d636ffc76811d666 Cr-Commit-Position: refs/heads/master@{#395538}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set.html View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css-grid-layout/grid-element-auto-repeat-get-set-expected.txt View 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +11 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 24 (11 generated)
Manuel Rego
4 years, 7 months ago (2016-05-23 11:55:53 UTC) #2
cbiesinger
lgtm
4 years, 7 months ago (2016-05-23 16:03:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001113002/1
4 years, 7 months ago (2016-05-23 19:33:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188267)
4 years, 7 months ago (2016-05-23 19:41:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001113002/1
4 years, 7 months ago (2016-05-23 19:49:54 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188274)
4 years, 7 months ago (2016-05-23 19:56:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001113002/1
4 years, 7 months ago (2016-05-23 20:25:55 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188299)
4 years, 7 months ago (2016-05-23 20:32:36 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001113002/1
4 years, 7 months ago (2016-05-23 21:53:57 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/188381)
4 years, 7 months ago (2016-05-23 22:03:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001113002/1
4 years, 7 months ago (2016-05-24 07:02:14 UTC) #21
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 07:06:48 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 07:08:11 UTC) #24
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e41b40417c0ba7a1f44a0cb6d636ffc76811d666
Cr-Commit-Position: refs/heads/master@{#395538}

Powered by Google App Engine
This is Rietveld 408576698