Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 2001053003: [build] Fix Makefile based (native) build. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Fix Makefile based (native) build. This fixes the Python include path after the GYP files have been relocated into another directory. It only affects 'make native', other targets have been fixed in previous changes already. R=jkummerow@chromium.org Committed: https://crrev.com/4267a2ebe7af9aa5d64e141f0a6492761fb37e95 Cr-Commit-Position: refs/heads/master@{#36432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Makefile View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Starzinger
This is a follow-up to: https://codereview.chromium.org/1938893002
4 years, 7 months ago (2016-05-23 08:47:14 UTC) #1
Jakob Kummerow
lgtm
4 years, 7 months ago (2016-05-23 08:47:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001053003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001053003/1
4 years, 7 months ago (2016-05-23 08:57:17 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-23 09:15:25 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 09:16:34 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4267a2ebe7af9aa5d64e141f0a6492761fb37e95
Cr-Commit-Position: refs/heads/master@{#36432}

Powered by Google App Engine
This is Rietveld 408576698