Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2001013004: Revert of Add OBB mounter Mojo interface (Closed)

Created:
4 years, 7 months ago by hashimoto
Modified:
4 years, 7 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, hidehiko+watch_chomium.org, qsr+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add OBB mounter Mojo interface (patchset #4 id:120001 of https://codereview.chromium.org/1995243002/ ) Reason for revert: Conflicting with https://codereview.chromium.org/1996933002 Original issue's description: > Add OBB mounte Mojo interface > > Add a new interface ObbMounter, and expose it to Android. > Actual features are not implemented yet. > > BUG=613480 > > Committed: https://crrev.com/4265d7151753f4e3a7a4cbe688b423c376dd9503 > Cr-Commit-Position: refs/heads/master@{#395557} TBR=hidehiko@chromium.org,rickyz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=613480 Committed: https://crrev.com/b535bb0624570cc4c9decbf972b4733ee4338bd7 Cr-Commit-Position: refs/heads/master@{#395560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -163 lines) Patch
M components/arc.gypi View 2 chunks +0 lines, -3 lines 0 comments Download
M components/arc/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M components/arc/arc_bridge_service.h View 8 chunks +0 lines, -14 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M components/arc/arc_service_manager.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 3 chunks +2 lines, -6 lines 0 comments Download
D components/arc/common/obb_mounter.mojom View 1 chunk +0 lines, -20 lines 0 comments Download
D components/arc/obb_mounter/arc_obb_mounter_bridge.h View 1 chunk +0 lines, -42 lines 0 comments Download
D components/arc/obb_mounter/arc_obb_mounter_bridge.cc View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
hashimoto
Created Revert of Add OBB mounter Mojo interface
4 years, 7 months ago (2016-05-24 10:12:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2001013004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2001013004/1
4 years, 7 months ago (2016-05-24 10:12:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 10:13:58 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 10:15:03 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b535bb0624570cc4c9decbf972b4733ee4338bd7
Cr-Commit-Position: refs/heads/master@{#395560}

Powered by Google App Engine
This is Rietveld 408576698