Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1996933002: arc: IPC definition of file system interfaces. (Closed)

Created:
4 years, 7 months ago by Shuhei Takahashi
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chomium.org, lhchavez+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yusukes+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: IPC definition of file system interfaces. User of the interface: https://codereview.chromium.org/2003533002/ Corresponding ARC changes: ag/1059173, ag/1058841, ag/1059172 BUG=b/28755411 TEST=Chrome builds. Committed: https://crrev.com/cbf0a29b010d0d588330a42fe9bb10e0d335eca9 Cr-Commit-Position: refs/heads/master@{#395542}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -3 lines) Patch
M components/arc.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/arc/arc_bridge_service.h View 8 chunks +14 lines, -0 lines 0 comments Download
M components/arc/arc_bridge_service.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M components/arc/common/arc_bridge.mojom View 4 chunks +8 lines, -3 lines 0 comments Download
A components/arc/common/file_system.mojom View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Shuhei Takahashi
lhchavez: PTAL rickyz: PTAL for mojom changes
4 years, 7 months ago (2016-05-20 11:03:01 UTC) #3
Luis Héctor Chávez
lgtm
4 years, 7 months ago (2016-05-20 15:20:04 UTC) #4
rickyz (no longer on Chrome)
mojo lgtm
4 years, 7 months ago (2016-05-24 04:02:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1996933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1996933002/1
4 years, 7 months ago (2016-05-24 06:36:54 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 08:08:09 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 08:09:35 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cbf0a29b010d0d588330a42fe9bb10e0d335eca9
Cr-Commit-Position: refs/heads/master@{#395542}

Powered by Google App Engine
This is Rietveld 408576698