media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522
Committed: https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848
Cr-Commit-Position: refs/heads/master@{#395366}

[Srirama, 2016-05-23 10:45:04]

Description was changed from

==========
fix


fix

BUG=
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h macros in core/html/
folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED ASSERT_WITH_SECURITY_IMPLICATION ->
SECURITY_DCHECK

BUG=596522
==========

[Srirama, 2016-05-23 10:45:22]

Description was changed from

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of base/logging.h macros in core/html/
folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED ASSERT_WITH_SECURITY_IMPLICATION ->
SECURITY_DCHECK

BUG=596522
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED ASSERT_WITH_SECURITY_IMPLICATION ->
SECURITY_DCHECK

BUG=596522
==========

[Srirama, 2016-05-23 10:45:39]

Description was changed from

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED ASSERT_WITH_SECURITY_IMPLICATION ->
SECURITY_DCHECK

BUG=596522
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522
==========

[Srirama, 2016-05-23 10:56:51]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-05-23 11:02:21]

PTAL

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLTrackElement.cpp (right):

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLTrackElement.cpp:274:
DCHECK_EQ(m_loader, loader);
We don't get any error for unused "loader" in Release build. So DCHECK_EQ should
be enough. What do you think?

[Srirama, 2016-05-23 11:02:28]

srirama.m@samsung.com changed reviewers:
+ fs@opera.com

[Srirama, 2016-05-23 11:02:28]

PTAL

[fs, 2016-05-23 11:09:11]

LGTM w/ one small nit

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3289:
DCHECK_LE((signed)numberOfChildren, 2);
DCHECK_LE(..., 2u);

I think is the more common form.

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLTrackElement.cpp (right):

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLTrackElement.cpp:274:
DCHECK_EQ(m_loader, loader);
On 2016/05/23 at 11:02:21, Srirama wrote:
> We don't get any error for unused "loader" in Release build. So DCHECK_EQ
should be enough. What do you think?

Seems fine to me. (Not sure why this was using ASSERT_UNUSED in the first
place.)

[Srirama, 2016-05-23 11:22:54]

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right):

https://codereview.chromium.org/2001013003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:3289:
DCHECK_LE((signed)numberOfChildren, 2);
On 2016/05/23 11:09:11, fs wrote:
> DCHECK_LE(..., 2u);
> 
> I think is the more common form.

Done.

[Srirama, 2016-05-23 11:23:03]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-05-23 11:23:03]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2001013003/#ps40001
(title: "address nit")

[commit-bot: I haz the power, 2016-05-23 11:23:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001013003/40001

[commit-bot: I haz the power, 2016-05-23 13:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 13:47:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Srirama, 2016-05-23 18:15:20]

The CQ bit was checked by srirama.m@samsung.com

[commit-bot: I haz the power, 2016-05-23 18:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2001013003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2001013003/40001

[commit-bot: I haz the power, 2016-05-23 18:20:19]

Description was changed from

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522
==========

[commit-bot: I haz the power, 2016-05-23 18:20:20]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-05-23 18:23:00]

Description was changed from

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522
==========

to

==========
media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Replaced wtf/Assertions.h macros in favor of
base/logging.h macros in core/html/ folder.

ASSERT, ASSERT_UNUSED -> DCHECK
ASSERT_NOT_REACHED -> NOTREACHED
ASSERT_WITH_SECURITY_IMPLICATION -> SECURITY_DCHECK

BUG=596522

Committed: https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848
Cr-Commit-Position: refs/heads/master@{#395366}
==========

[commit-bot: I haz the power, 2016-05-23 18:23:01]

Patchset 2 (id:??) landed as
https://crrev.com/3457a685fe7ed2606c33167570222df0ecda8848
Cr-Commit-Position: refs/heads/master@{#395366}