third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp - Issue 2001013003: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp

Issue 2001013003: media: Replace wtf/Assertions.h macros in favor of base/logging.h macros" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address nit Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.h ('k') | third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp

index ddbca23a8dca4b59dcb1d81998945c9691222a2b..45baeee686422bc5e60875db56b63dcc492aa276 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElementTypes.cpp

@@ -58,7 +58,7 @@ const HTMLMediaElement* toParentMediaElement(const Node* node)

MediaControlElementType mediaControlElementType(const Node* node)

{

- ASSERT_WITH_SECURITY_IMPLICATION(node->isMediaControlElement());

+ SECURITY_DCHECK(node->isMediaControlElement());

const HTMLElement* element = toHTMLElement(node);

if (isHTMLInputElement(*element))

return static_cast<const MediaControlInputElement*>(element)->displayType();