Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Unified Diff: services/catalog/entry.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/catalog/entry.cc
diff --git a/services/catalog/entry.cc b/services/catalog/entry.cc
index 9d477b13815913b53c69f5a9f72f2525d1156641..c9d9d0783a03ec408680d95708425e56a1711c03 100644
--- a/services/catalog/entry.cc
+++ b/services/catalog/entry.cc
@@ -14,9 +14,8 @@ namespace {
bool ReadStringSet(const base::ListValue& list_value,
std::set<std::string>* string_set) {
DCHECK(string_set);
- for (auto i = list_value.begin(); i != list_value.end(); ++i) {
+ for (const auto& value_value : list_value) {
std::string value;
- const base::Value* value_value = *i;
if (!value_value->GetAsString(&value)) {
LOG(ERROR) << "Entry::Deserialize: list member must be a string";
return false;

Powered by Google App Engine
This is Rietveld 408576698