Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Unified Diff: remoting/protocol/http_ice_config_request.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/http_ice_config_request.cc
diff --git a/remoting/protocol/http_ice_config_request.cc b/remoting/protocol/http_ice_config_request.cc
index 7e8e5aabda1800cba38d215a89db226e88940292..7364341169190c08b10fbbf17aebb21d3dd8a41f 100644
--- a/remoting/protocol/http_ice_config_request.cc
+++ b/remoting/protocol/http_ice_config_request.cc
@@ -161,7 +161,7 @@ void HttpIceConfigRequest::OnResponse(const UrlRequest::Result& result) {
// Parse iceServers list and store them in |ice_config|.
bool errors_found = false;
- for (base::Value* server : *ice_servers_list) {
+ for (const auto& server : *ice_servers_list) {
base::DictionaryValue* server_dict;
if (!server->GetAsDictionary(&server_dict)) {
errors_found = true;
@@ -180,7 +180,7 @@ void HttpIceConfigRequest::OnResponse(const UrlRequest::Result& result) {
std::string password;
server_dict->GetString("credential", &password);
- for (base::Value* url : *urls_list) {
+ for (const auto& url : *urls_list) {
std::string url_str;
if (!url->GetAsString(&url_str)) {
errors_found = true;

Powered by Google App Engine
This is Rietveld 408576698