Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: extensions/browser/api/device_permissions_manager.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/device_permissions_manager.cc
diff --git a/extensions/browser/api/device_permissions_manager.cc b/extensions/browser/api/device_permissions_manager.cc
index fd9d0edbd1dd3927fc5fcd6ab3dfbdbae5de2d90..5737ad3ab0817568ab353a3b2069d297871837c3 100644
--- a/extensions/browser/api/device_permissions_manager.cc
+++ b/extensions/browser/api/device_permissions_manager.cc
@@ -252,7 +252,7 @@ std::set<scoped_refptr<DevicePermissionEntry>> GetDevicePermissionEntries(
return result;
}
- for (const base::Value* entry : *devices) {
+ for (const auto& entry : *devices) {
const base::DictionaryValue* entry_dict;
if (entry->GetAsDictionary(&entry_dict)) {
scoped_refptr<DevicePermissionEntry> device_entry =

Powered by Google App Engine
This is Rietveld 408576698