components/update_client/component_patcher.h - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/update_client/component_patcher.h

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix various builds. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromeos/network/prohibited_technologies_handler.cc ('K') | « components/signin/core/browser/account_tracker_service.cc ('k') | components/update_client/component_patcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/update_client/component_patcher.h

diff --git a/components/update_client/component_patcher.h b/components/update_client/component_patcher.h

index 0d11ad2ca3716a2ecd5a98ae376ebea2cd58e467..9714abe27e21ddfdd71e6b81ded8f67b0dfea8b7 100644

--- a/components/update_client/component_patcher.h

+++ b/components/update_client/component_patcher.h

@@ -91,7 +91,7 @@ class ComponentPatcher : public base::RefCountedThreadSafe<ComponentPatcher> {

scoped_refptr<OutOfProcessPatcher> out_of_process_patcher_;

ComponentUnpacker::Callback callback_;

std::unique_ptr<base::ListValue> commands_;

- base::ValueVector::const_iterator next_command_;

+ base::ListValue::const_iterator next_command_;

scoped_refptr<DeltaUpdateOp> current_operation_;

scoped_refptr<base::SequencedTaskRunner> task_runner_;