Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix various builds. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
index 786c7e5f06f81cefcf938de7024bd5f34300ba97..44ab9c1a99ebd11185d9bc688966d8a58b4b0168 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.cc
@@ -54,9 +54,8 @@ const StringToConstant kDataReductionProxyBypassActionTypeTable[] = {
std::string JoinListValueStrings(base::ListValue* list_value) {
std::vector<std::string> values;
- for (auto it = list_value->begin(); it != list_value->end(); ++it) {
+ for (const auto& value : *list_value) {
std::string value_string;
- base::Value* value = *it;
if (!value->GetAsString(&value_string))
return std::string();

Powered by Google App Engine
This is Rietveld 408576698