remoting/test/host_list_fetcher.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/test/host_list_fetcher.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/test/host_list_fetcher.cc

diff --git a/remoting/test/host_list_fetcher.cc b/remoting/test/host_list_fetcher.cc

index 3b1c6b4fa7124e7e3299affa334be53fc7a68d12..5cb46d565f37feef3e499f36a990b528dece06c1 100644

--- a/remoting/test/host_list_fetcher.cc

+++ b/remoting/test/host_list_fetcher.cc

@@ -88,7 +88,7 @@ bool HostListFetcher::ProcessResponse(

// Any host_info with malformed data will not be added to the hostlist.

base::DictionaryValue* host_dict;

- for (base::Value* host_info : *hosts) {

+ for (const auto& host_info : *hosts) {

HostInfo host;

if (host_info->GetAsDictionary(&host_dict) &&

host.ParseHostInfo(*host_dict)) {

« no previous file with comments | « remoting/test/host_info.cc ('k') | services/catalog/entry.cc » ('j') | no next file with comments »