Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: remoting/test/host_info.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/protocol/http_ice_config_request.cc ('k') | remoting/test/host_list_fetcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/test/host_info.cc
diff --git a/remoting/test/host_info.cc b/remoting/test/host_info.cc
index c8069739ccbc1f66e98221706d0371c2eed3f950..5f5321f65ecf56e9d303e03b3d870eaab6c120b7 100644
--- a/remoting/test/host_info.cc
+++ b/remoting/test/host_info.cc
@@ -20,7 +20,7 @@ bool HostInfo::ParseHostInfo(const base::DictionaryValue& host_info) {
// Add TokenUrlPatterns to HostInfo.
if (host_info.GetList("tokenUrlPatterns", &list_value)) {
if (!list_value->empty()) {
- for (base::Value* item : *list_value) {
+ for (const auto& item : *list_value) {
std::string token_url_pattern;
if (!item->GetAsString(&token_url_pattern)) {
return false;
« no previous file with comments | « remoting/protocol/http_ice_config_request.cc ('k') | remoting/test/host_list_fetcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698