dbus/values_util.cc - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dbus/values_util.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/child/v8_value_converter.h ('k') | extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: dbus/values_util.cc

diff --git a/dbus/values_util.cc b/dbus/values_util.cc

index ed435a193680ff368b2f3e757d062de5676e12ec..88b7f02ccb9d7ac576908263a0ccd0b485d9fa27 100644

--- a/dbus/values_util.cc

+++ b/dbus/values_util.cc

@@ -279,9 +279,7 @@ void AppendValueData(MessageWriter* writer, const base::Value& value) {

value.GetAsList(&list);

dbus::MessageWriter array_writer(NULL);

writer->OpenArray("v", &array_writer);

- for (base::ListValue::const_iterator iter = list->begin();

- iter != list->end(); ++iter) {

- const base::Value* value = *iter;

+ for (const auto& value : *list) {

AppendValueDataAsVariant(&array_writer, *value);

}

writer->CloseContainer(&array_writer);