Index: content/public/child/v8_value_converter.h |
diff --git a/content/public/child/v8_value_converter.h b/content/public/child/v8_value_converter.h |
index a7a0e8946f0806772687d78bfe0d1b03cf58ae33..67e3025ff1a6beb68f0d32d4a193584deb007cb2 100644 |
--- a/content/public/child/v8_value_converter.h |
+++ b/content/public/child/v8_value_converter.h |
@@ -105,6 +105,7 @@ class CONTENT_EXPORT V8ValueConverter { |
// Unsupported types are replaced with null. If an array or object throws |
// while setting a value, that property or item is skipped, leaving a hole in |
// the case of arrays. |
+ // TODO(dcheng): This should just take a const reference. |
virtual v8::Local<v8::Value> ToV8Value( |
const base::Value* value, |
v8::Local<v8::Context> context) const = 0; |
@@ -118,6 +119,7 @@ class CONTENT_EXPORT V8ValueConverter { |
// Likewise, if an object throws while converting a property it will not be |
// converted, whereas if an array throws while converting an item it will be |
// converted to Value(TYPE_NULL). |
+ // TODO(dcheng): This should return a unique_ptr. |
virtual base::Value* FromV8Value(v8::Local<v8::Value> value, |
v8::Local<v8::Context> context) const = 0; |
}; |