Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: components/url_matcher/url_matcher_factory.cc

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More fixes Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/url_matcher/url_matcher_factory.cc
diff --git a/components/url_matcher/url_matcher_factory.cc b/components/url_matcher/url_matcher_factory.cc
index e7ce483cd025fe32fec90543d86b53a4dbad4509..848e5d469396040fed208f4664e97ca3ada2edd7 100644
--- a/components/url_matcher/url_matcher_factory.cc
+++ b/components/url_matcher/url_matcher_factory.cc
@@ -248,9 +248,7 @@ std::unique_ptr<URLMatcherPortFilter> URLMatcherFactory::CreateURLMatcherPorts(
return nullptr;
}
- for (base::ListValue::const_iterator i = value_list->begin();
- i != value_list->end(); ++i) {
- base::Value* entry = *i;
+ for (const auto& entry : *value_list) {
int port = 0;
base::ListValue* range = NULL;
if (entry->GetAsInteger(&port)) {
« no previous file with comments | « components/update_client/component_patcher.cc ('k') | content/browser/android/java/gin_java_method_invocation_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698