content/browser/android/java/gin_java_method_invocation_helper.h - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/android/java/gin_java_method_invocation_helper.h

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/url_matcher/url_matcher_factory.cc ('k') | content/browser/android/java/gin_java_method_invocation_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/android/java/gin_java_method_invocation_helper.h

diff --git a/content/browser/android/java/gin_java_method_invocation_helper.h b/content/browser/android/java/gin_java_method_invocation_helper.h

index b2c0992eaa4d17ef315f6bbe42d580cf6ae89a6f..6582ccfe6b17f792729fb6896af88f6682c003f1 100644

--- a/content/browser/android/java/gin_java_method_invocation_helper.h

+++ b/content/browser/android/java/gin_java_method_invocation_helper.h

@@ -73,12 +73,12 @@ class CONTENT_EXPORT GinJavaMethodInvocationHelper

~GinJavaMethodInvocationHelper();

void BuildObjectRefsFromListValue(DispatcherDelegate* dispatcher,

- const base::Value* list_value);

+ const base::Value& list_value);

void BuildObjectRefsFromDictionaryValue(DispatcherDelegate* dispatcher,

- const base::Value* dict_value);

+ const base::Value& dict_value);

bool AppendObjectRef(DispatcherDelegate* dispatcher,

- const base::Value* raw_value);

+ const base::Value& raw_value);

void InvokeMethod(jobject object,

jclass clazz,

« no previous file with comments | « components/url_matcher/url_matcher_factory.cc ('k') | content/browser/android/java/gin_java_method_invocation_helper.cc » ('j') | no next file with comments »