components/policy/core/common/policy_test_utils.h - Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/common/policy_test_utils.h

Issue 2000803003: Use std::unique_ptr for base::DictionaryValue and base::ListValue's internal store. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More fixes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/policy/core/common/policy_loader_mac_unittest.cc ('k') | components/policy/core/common/policy_test_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/common/policy_test_utils.h

diff --git a/components/policy/core/common/policy_test_utils.h b/components/policy/core/common/policy_test_utils.h

index 62fd4bd58d3647fec7e794bcb9dfff50ac652f20..c76a7bb63a74700f014030213d56031bb2ff6b1d 100644

--- a/components/policy/core/common/policy_test_utils.h

+++ b/components/policy/core/common/policy_test_utils.h

@@ -52,7 +52,7 @@ bool PolicyServiceIsEmpty(const PolicyService* service);

// Converts a base::Value to the equivalent CFPropertyListRef.

// The returned value is owned by the caller.

-CFPropertyListRef ValueToProperty(const base::Value* value);

+CFPropertyListRef ValueToProperty(const base::Value& value);

#endif

« no previous file with comments | « components/policy/core/common/policy_loader_mac_unittest.cc ('k') | components/policy/core/common/policy_test_utils.cc » ('j') | no next file with comments »